Skip to content

fix(firestore-bigquery-change-tracker): validation and partitioning fixes #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

fix(firestore-bigquery-change-tracker): validation and partitioning fixes #2435

wants to merge 9 commits into from

Conversation

CorieW
Copy link
Member

@CorieW CorieW commented May 23, 2025

Resolves #2196

  • Fixes BigQuery SQL table Time Partitioning option type being set to DAY

  • Fixes following configuration:

    • BigQuery SQL table Time Partitioning option type: HOUR
    • BigQuery Time Partitioning column name: partition_column
    • Firestore Document field name for BigQuery SQL Time Partitioning field option: NONE
    • BigQuery SQL Time Partitioning table schema field(column) type: omit

  • Tested

@cabljac cabljac self-requested a review May 27, 2025 08:35
cabljac
cabljac reviewed May 29, 2025
View reviewed changes
@cabljac cabljac self-requested a review June 3, 2025 16:18
@cabljac
Copy link
Contributor

cabljac commented Jun 10, 2025

Closing this in favour of #2444

@cabljac cabljac closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabljac cabljac Awaiting requested review from cabljac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [firestore-bigquery-export] Table not partitioned despite using default _PARTITIONTIME pseudo column
2 participants
@CorieW @cabljac