Skip to content

Commit

Permalink
fix(firestore-bigquery-export): make MAX_DISPATCHES_PER_SECOND take e…
Browse files Browse the repository at this point in the history
…ffect (#1907)
  • Loading branch information
jauntybrain authored Jan 11, 2024
1 parent b87ee50 commit 2ffae36
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions firestore-bigquery-export/extension.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,8 @@ params:
This parameter will set the maximum number of syncronised documents per second with BQ. Please note, any other external updates to a Big Query table will be included within this quota.
Ensure that you have a set a low enough number to componsate. Defaults to 10.
type: string
validationRegex: ^(?:[1-9]|\d{2,3}|[1-4]\d{3})$
validationErrorMessage: Please select a number between 1 and 100
validationRegex: ^([1-9]|[1-9][0-9]|[1-4][0-9]{2}|500)$
validationErrorMessage: Please select a number between 1 and 500
example: 10
required: false

Expand Down
2 changes: 1 addition & 1 deletion firestore-bigquery-export/functions/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const syncBigQuery = functions.tasks
},
rateLimits: {
maxConcurrentDispatches: 1000,
maxDispatchesPerSecond: 500,
maxDispatchesPerSecond: config.maxDispatchesPerSecond,
},
})
.onDispatch(
Expand Down

0 comments on commit 2ffae36

Please sign in to comment.