Fix DB and Firestore modules not working without common module#942
Closed
SUPERCILEX wants to merge 1 commit intofirebase:masterfrom
SUPERCILEX:patch-1
Closed
Fix DB and Firestore modules not working without common module#942SUPERCILEX wants to merge 1 commit intofirebase:masterfrom SUPERCILEX:patch-1
SUPERCILEX wants to merge 1 commit intofirebase:masterfrom
SUPERCILEX:patch-1
Conversation
Collaborator
Author
|
@samtstern Hmmm, JitPack is broken without the common module. I have no idea how the POM stuff works, but does just adding the common module to the library work? Or are you working on another solution? PS: if the firebase-ui dep is broken without the common module, I think we should either kill it or publish the common module. |
Collaborator
Author
|
Nevermind, I've seen #944. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#941