Remove io.fabric.ApiKey override#905
Merged
samtstern merged 1 commit intofirebase:version-2.3.1-devfrom Sep 12, 2017
Merged
Conversation
Causes problems with Fabric SDK because it is present after manifest merger.
Contributor
|
LGTM will merge once build passes |
Collaborator
|
@asfalcone can you rotate the screen in the auth method picker activity and make sure there are no logs or leaks? |
Contributor
Author
|
@SUPERCILEX Will do and will update with output here shortly 👍 |
Contributor
Author
|
TwitterKit 3.0.0 no longer depends on Fabric so there is no need to have the Fabric ApiKey override for the old behavior. Rotate Nothing sketchy in logcat and no leaks @SUPERCILEX |
Collaborator
|
Yep, LGTM! I just wanted to be safe rather than sorry. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #904
Twitter auth is no longer part of Fabric (which is why this was added) and this override causes problems for Fabric users trying initialize without an ApiKey