Skip to content

Remove io.fabric.ApiKey override#905

Merged
samtstern merged 1 commit intofirebase:version-2.3.1-devfrom
asfalcone:patch-1
Sep 12, 2017
Merged

Remove io.fabric.ApiKey override#905
samtstern merged 1 commit intofirebase:version-2.3.1-devfrom
asfalcone:patch-1

Conversation

@asfalcone
Copy link
Contributor

Fixes #904

Twitter auth is no longer part of Fabric (which is why this was added) and this override causes problems for Fabric users trying initialize without an ApiKey

Causes problems with Fabric SDK because it is present after manifest merger.
@samtstern
Copy link
Contributor

LGTM will merge once build passes

@SUPERCILEX
Copy link
Collaborator

@asfalcone can you rotate the screen in the auth method picker activity and make sure there are no logs or leaks?

@asfalcone
Copy link
Contributor Author

@SUPERCILEX Will do and will update with output here shortly 👍

@asfalcone
Copy link
Contributor Author

TwitterKit 3.0.0 no longer depends on Fabric so there is no need to have the Fabric ApiKey override for the old behavior.

09-12 15:14:39.625 31596-2296/com.firebase.uidemo V/FA: Inactivity, disconnecting from the service
09-12 15:14:40.972 31596-2296/com.firebase.uidemo V/FA: Recording user engagement, ms: 6405
09-12 15:14:40.972 31596-2296/com.firebase.uidemo V/FA: Using measurement service
09-12 15:14:40.972 31596-2296/com.firebase.uidemo V/FA: Connecting to remote service
09-12 15:14:40.980 31596-2296/com.firebase.uidemo V/FA: Activity paused, time: 544303235
09-12 15:14:40.983 31596-2296/com.firebase.uidemo D/FA: Logging event (FE): user_engagement(_e), Bundle[{firebase_event_origin(_o)=auto, engagement_time_msec(_et)=6405, firebase_screen_class(_sc)=AuthMethodPickerActivity, firebase_screen_id(_si)=4053213049175316774}]

Rotate

09-12 15:14:40.994 31596-31596/com.firebase.uidemo V/FA: onActivityCreated
09-12 15:14:41.005 31596-31596/com.firebase.uidemo D/AutoManageHelper: starting AutoManage for client 19 false null
09-12 15:14:41.013 31596-31596/com.firebase.uidemo D/AutoManageHelper: onStart true {19=com.google.android.gms.internal.zzbau$zza@577058b}
09-12 15:14:41.035 31596-2296/com.firebase.uidemo V/FA: Using measurement service
09-12 15:14:41.035 31596-2296/com.firebase.uidemo V/FA: Connection attempt already in progress
09-12 15:14:41.035 31596-2296/com.firebase.uidemo V/FA: Using measurement service
09-12 15:14:41.035 31596-2296/com.firebase.uidemo V/FA: Connection attempt already in progress
09-12 15:14:41.036 31596-2296/com.firebase.uidemo V/FA: Activity resumed, time: 544303282
09-12 15:14:41.038 31596-31596/com.firebase.uidemo D/AutoManageHelper: onStart true {19=com.google.android.gms.internal.zzbau$zza@577058b}
09-12 15:14:41.039 31596-2296/com.firebase.uidemo D/FA: Connected to remote service
09-12 15:14:41.040 31596-2296/com.firebase.uidemo V/FA: Processing queued up service tasks: 3
09-12 15:14:46.055 31596-2296/com.firebase.uidemo V/FA: Inactivity, disconnecting from the service

Nothing sketchy in logcat and no leaks @SUPERCILEX

@SUPERCILEX
Copy link
Collaborator

Yep, LGTM! I just wanted to be safe rather than sorry. 😄

@samtstern samtstern merged commit 868247f into firebase:version-2.3.1-dev Sep 12, 2017
@samtstern samtstern added this to the 2.4.0 milestone Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants