Fix phone verification progress dialog bugs on pre-L devices#817
Merged
samtstern merged 3 commits intofirebase:version-2.1.2-devfrom Aug 1, 2017
SUPERCILEX:progress_dialog
Merged
Fix phone verification progress dialog bugs on pre-L devices#817samtstern merged 3 commits intofirebase:version-2.1.2-devfrom SUPERCILEX:progress_dialog
samtstern merged 3 commits intofirebase:version-2.1.2-devfrom
SUPERCILEX:progress_dialog
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Contributor
|
@SUPERCILEX you're on a roll today! Won't be able to get to this one until Monday though. |
Collaborator
Author
|
@samtstern Haha, that was the last of it! 😄 SGTM! |
Contributor
|
Ok since we have this fatal crash issue I am going to push this out to |
Collaborator
Author
|
@samtstern SGTM |
Contributor
|
Finally had time to check this, LGTM. Thanks for tackling this! |
Collaborator
Author
|
@samtstern No prob, glad to see it merged! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samtstern The dialog looks like this pre-L:
Pretty gross, right? 😆
Anyway, since
ProgressDialogis deprecated in Android O and we have a layout that basically just recreates it, I've updatedCompletableProgressDialogto be a plain oldDialogFragmentand it now looks like this pre-L: