Add pull-to-loadmore more to RecyclerViewDemoActivity.#7
Closed
Add pull-to-loadmore more to RecyclerViewDemoActivity.#7
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Contributor
|
Hi there friendly Googlebot. I did indeed author these commits. :-) |
samtstern
added a commit
that referenced
this pull request
Oct 3, 2017
TomWayne98
pushed a commit
to TomWayne98/FirebaseUI-Android
that referenced
this pull request
Oct 25, 2017
Fix anonymous users from SmartLock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@puf
Frank, please review this change which adds a pull-to-loadmore feature to RecyclerViewDemoActivity. It's implemented by updating the query passed in when user scrolls up.
The key change is in FirebaseArray.java. In the onChildAdded() method, I will first test whether the snapshot is already loaded. If it's already loaded we won't load it twice.