Modernize database tests and cleanup#579
Modernize database tests and cleanup#579samtstern merged 4 commits intofirebase:version-1.2.0-devfrom SUPERCILEX:db-tests
Conversation
Moved TestUtils into correct directory for its package. Removed redundant tests. Reformatted some code and renamed methods for clarity.
# Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseArray.java
SUPERCILEX
changed the title
|
|
||
| @Test | ||
| public void testPushIncreasesSize() throws Exception { | ||
| assertEquals(3, mArray.getCount()); |
There was a problem hiding this comment.
Was dropping this line intentional?
There was a problem hiding this comment.
@CodingDoug removed it in his PR. @samtstern If you'd like I'll add it back (I'm not sure why he removed it).
There was a problem hiding this comment.
It does seem a little strange to assert that the count after is "4" but not assert that it was "3" before. 4 is only correct if it's one more than the initial count.
There was a problem hiding this comment.
@CodingDoug thanks for the explanation!
|
@CodingDoug any issues with merging in your test changes now since we all agree they are good? You can then rebase your PR and it will only contain the |
|
@samtstern Yeah, that's fine. I promise I'll get back to the rest of this PR some time! |
3 participants
@samtstern Since it looks like #481 isn't going to be merged anytime soon, this PR gives @CodingDoug credit for his work while allowing us to move forward with modernized tests.