feat(AuthUIConfiguration): implement configuration model, DSL builder and tests#2216
Merged
Lyokone merged 9 commits intofirebase:version-10.0.0-devfrom Sep 19, 2025
Merged
feat(AuthUIConfiguration): implement configuration model, DSL builder and tests#2216Lyokone merged 9 commits intofirebase:version-10.0.0-devfrom
Lyokone merged 9 commits intofirebase:version-10.0.0-devfrom
Conversation
Member
demolaf
commented
Sep 15, 2025
demolaf
commented
- Add AuthUIConfiguration data class with all properties
- Implement authUIConfiguration DSL builder function
- Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
- Create comprehensive tests for default and custom configurations
Lyokone
reviewed
Sep 16, 2025
auth/src/main/java/com/firebase/ui/auth/compose/configuration/AuthProvider.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/compose/configuration/AuthUITheme.kt
Outdated
Show resolved
Hide resolved
| import kotlin.reflect.KMutableProperty | ||
| import kotlin.reflect.full.memberProperties | ||
|
|
||
| class AuthUIConfigurationTest { |
Contributor
There was a problem hiding this comment.
Would like to see a test for the Builder pattern as well
Member
Author
There was a problem hiding this comment.
not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?
Lyokone
reviewed
Sep 16, 2025
| /** | ||
| * The expected length of the SMS verification code. Defaults to 6. | ||
| */ | ||
| val smsCodeLength: Int = 6, |
Contributor
There was a problem hiding this comment.
is this verified against what we get from Firebase by default?
Member
Author
There was a problem hiding this comment.
I got this from the API Design docs, is there somewhere else I could check this from?
Comment on lines
+25
to
+40
| interface AuthUIStringProvider { | ||
| fun initializing(): String | ||
| fun signInWithGoogle(): String | ||
| fun invalidEmail(): String | ||
| fun passwordsDoNotMatch(): String | ||
| } | ||
|
|
||
| class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider { | ||
| override fun initializing(): String = "" | ||
|
|
||
| override fun signInWithGoogle(): String = | ||
| context.getString(R.string.fui_sign_in_with_google) | ||
|
|
||
| override fun invalidEmail(): String = "" | ||
|
|
||
| override fun passwordsDoNotMatch(): String = "" |
Contributor
There was a problem hiding this comment.
We'll need documentation for this
Comment on lines
21
to
52
| sealed class PasswordRule { | ||
| /** | ||
| * Requires the password to have at least a certain number of characters. | ||
| */ | ||
| data class MinimumLength(val value: Int) : PasswordRule() | ||
|
|
||
| /** | ||
| * Requires the password to contain at least one uppercase letter (A-Z). | ||
| */ | ||
| object RequireUppercase : PasswordRule() | ||
|
|
||
| /** | ||
| * Requires the password to contain at least one lowercase letter (a-z). | ||
| */ | ||
| object RequireLowercase: PasswordRule() | ||
|
|
||
| /** | ||
| * Requires the password to contain at least one numeric digit (0-9). | ||
| */ | ||
| object RequireDigit: PasswordRule() | ||
|
|
||
| /** | ||
| * Requires the password to contain at least one special character (e.g., !@#$%^&*). | ||
| */ | ||
| object RequireSpecialCharacter: PasswordRule() | ||
|
|
||
| /** | ||
| * Defines a custom validation rule using a regular expression and provides a specific error | ||
| * message on failure. | ||
| */ | ||
| data class Custom(val regex: Regex, val errorMessage: String) | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules
Member
Author
There was a problem hiding this comment.
Yeah this is a different ticket too here, don't want to cramp them all in a single PR.
replaced sealed with abstract class, data with regular class use isXX prefix for booleans
Lyokone
approved these changes
Sep 18, 2025
…droid into feat/C1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.