Skip to content

test(firestore): create FirestorePagingSourceTest #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2021
Merged

test(firestore): create FirestorePagingSourceTest #1989

merged 3 commits into from
Aug 4, 2021

Conversation

@thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Aug 3, 2021

This should recreate the test that was deleted in #1915

The CI build should fail at the moment, but it'll pass once #1988 is merged.

@google-cla google-cla bot added the cla: yes label Aug 3, 2021
@samtstern samtstern changed the base branch from master to version-8.0.1-dev August 4, 2021 09:54
@samtstern
Copy link
Contributor

samtstern commented Aug 4, 2021

Thanks for remembering this!

@samtstern samtstern marked this pull request as ready for review August 4, 2021 10:01
@samtstern samtstern self-requested a review as a code owner August 4, 2021 10:01
@thatfiredev thatfiredev mentioned this pull request Aug 4, 2021
Merged
@samtstern samtstern merged commit 0960234 into firebase:version-8.0.1-dev Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samtstern samtstern samtstern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thatfiredev @samtstern