refactor(database): migrate to paging 3 #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aseUI-Android into rpf-rtdb-paging-3 � Conflicts: � database/src/main/java/com/firebase/ui/database/paging/FirebaseRecyclerPagingAdapter.java
thatfiredev
commented
Jul 29, 2021
samtstern
approved these changes
Jul 30, 2021
| } | ||
|
|
||
| return Single.fromCallable(() -> { | ||
| Tasks.await(task); |
There was a problem hiding this comment.
I think this will throw if the Tasks fails:
https://developers.google.com/android/reference/com/google/android/gms/tasks/Tasks#await(com.google.android.gms.tasks.Task%3CTResult%3E)
So we can't rely on getting to the next line. Although I think it's fine since you re-throw at the bottom, but I just don't think you'll ever get that far.
Also we can probably remove the task.isSuccessful nesting since we know if we even get to the next line, the task is successful.
There was a problem hiding this comment.
@samtstern Interesting, I didn't know that.
I have wrapped it around a try/catch so that developers using FirebaseUI can get the original cause instead of await's ExecutionException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should:
See #1982