Check mEmail for empty String to prevent "credential identifier cannot be empty" error #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made code more robust, should fix firebase#141
| @Override | ||
| public void onConnected(@Nullable Bundle bundle) { | ||
| if (mEmail == null) { | ||
| if (mEmail == null || mEmail.equals("")) { |
Contributor
There was a problem hiding this comment.
This line can be replaced with TextUtils.isEmpty(mEmail)
Contributor
There was a problem hiding this comment.
We should investigate under what circumstances a null / empty email address ever arrives here. I agree with sam however that if (TextUtils.isEmpty(mEmail) is a more descriptive check here.
There was a problem hiding this comment.
Empty email issue happens due to privacy setting of some users, where you get name and profile image but email is null
Contributor
|
@iainmcgin please review. |
Collaborator
10 tasks
Contributor
|
#357 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made code more robust, should fix #141