Fix incorrect horizontal logo padding#1458
Fix incorrect horizontal logo padding#1458SUPERCILEX wants to merge 1 commit intofirebase:version-4.2.1-devfrom SUPERCILEX:horizontal-logo
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
@SUPERCILEX I was just working on this, but you beat me to it! |
| app:layout_constraintEnd_toStartOf="@+id/container" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:layout_constraintBottom_toTopOf="@+id/main_tos_and_pp" | ||
| app:layout_constraintVertical_weight="2" |
There was a problem hiding this comment.
This works, but I was also thinking what we might want is to center the logo between the top of the parent and the top of the ToS/PP. What do you think about that?
There was a problem hiding this comment.
I think it's already doing that, right? At least, that's what I'm getting from this screenshot. The issue seems to be that there's a lot more padding than we're used to.
|
@SUPERCILEX I took a slightly different approach here: WDYT? Not trying to step on your toes, I was already working on a fix when you sent your PR so I figured I might as well finish it and then we can decide. |
|
@samtstern well I guess it's step-over-each-others-toes week 😂. Anyway, I think we should go with your PR since it has nice sample changes, but you'll probably have to use this PR's layout changes. (I'll post the bug on your PR.) |
2 participants
Fixes #1434