Avoid error when canceling google signin#1443
Merged
samtstern merged 3 commits intofirebase:version-4.2.0-devfrom Sep 12, 2018
Merged
Avoid error when canceling google signin#1443samtstern merged 3 commits intofirebase:version-4.2.0-devfrom
samtstern merged 3 commits intofirebase:version-4.2.0-devfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
I signed it |
|
CLAs look good, thanks! |
SUPERCILEX
approved these changes
Sep 12, 2018
Collaborator
SUPERCILEX
left a comment
There was a problem hiding this comment.
LGTM with the styling fixed
Contributor
|
@diedu89 thank you! |
Contributor
|
Merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if user cancel signin with google an error is shown as a toast instead of the message of user cancellation #1404, to avoid this play-services-auth is upgraded
Also the handle of the error code 12501 is added in order to set an UserCancellationException instead of FirebaseUiException