Conversation
Change-Id: Ic2cd64fb53cd5b932c8b2920d2bfb084e70cc48e
SUPERCILEX
reviewed
Aug 29, 2018
| GoogleAuthProvider.PROVIDER_ID, | ||
| FacebookAuthProvider.PROVIDER_ID, | ||
| TwitterAuthProvider.PROVIDER_ID, | ||
| GithubAuthProvider.PROVIDER_ID, |
Collaborator
There was a problem hiding this comment.
Whoa, that's a public API, not part of TestConstants. 😛 I wasn't merged up with master before so I didn't see the changes. Here's how I fixed it:
If we did that here:
it should work.
Collaborator
There was a problem hiding this comment.
But yeah, I couldn't find a way to include GitHub in the tests. 😢
Contributor
Author
There was a problem hiding this comment.
Oh holy crap haha I did not look at my file path!
Change-Id: I5e8824935940c9e1a876fea7da0969b97755730e
SUPERCILEX
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1425
We can't add a dependency from
authtoauth-githubbecause that would be circular.Maybe we need an
auth-commonmodule in the long term? That would be a bit unfortunate, but could fix the issue.