Fix publishing#1334
Merged
samtstern merged 3 commits intofirebase:masterfrom Jun 6, 2018
SUPERCILEX:publishing
Merged
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Contributor
|
Im gonna be out until Wednesday but just wanted to say thanks for looking
into this! Had me pretty stumped and I wasn't going about it the right
way.
…On Thu, May 31, 2018, 9:18 PM Alex Saveau ***@***.***> wrote:
@SUPERCILEX <https://github.com/SUPERCILEX> requested your review on:
firebase/FirebaseUI-Android#1334
<#1334> Fix publishing
as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1334 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6hG-UD9jfXZCgZpWj01cyBwD1bK0ks5t4MCXgaJpZM4UWFP9>
.
|
Collaborator
Author
|
No problem, see you Wednesday! 😊 |
Contributor
|
@SUPERCILEX this works great! Thanks again for bailing us out on this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voila! We're back into the
.gradle.ktsworld. Publishing works with my account, but please check yours so we can avoid yesterday. 😉As for Gradle 4.8, I have a PR ready to roll once bintray/gradle-bintray-plugin#234 is resolved. Turns out we weren't alone!
BTW, here's what I'm running:
I doubt the
-Pparams are necessary for you, but Windows isn't designed for terminals. 🤷♂️Fixes #1330