Fix rotation bugs#1208
Fix rotation bugs#1208samtstern merged 6 commits intofirebase:version-3.3.0-devfrom SUPERCILEX:rotate
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
@SUPERCILEX this will be the final |
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/viewmodel/ResourceObserver.java
|
For sure, I just wanted to get these PRs into the wild. 😁 |
| return; | ||
| } | ||
|
|
||
| onSaveOperation(resource); |
There was a problem hiding this comment.
- Why is
ResourceObservernot good for this situation? - Having a usable
Resource<Void>is kind of strange ... but maybe I should just get over it.
There was a problem hiding this comment.
That was you! 😆 Nah, I think we weren't doing it because we didn't want to show a loading dialog, but now that I'm looking at the code, we do have a task running in the background so we should be showing one. 🤷♂️, I'll use the ResourceObserver 😄.
There was a problem hiding this comment.
Huh, the void thing is kinda ugly: it messed with our nullability annotations. Not sure how to fix it though without getting rid of the Resource for this altogether.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
|
2 participants
Built on top of #1207
Darn it! I should have seen this coming, but the usable failure stuff doesn't cover success states or non-usable failure states! 🤦♂️
TLDR: I just made
Resourceimmutable again and added back theisUsedmethod which is now checked only once in theResourceObserver. The main beef you had with that method was that we were checking it everytime, right? Now we aren't. 😁