Skip to content

Kill SignInDelegate ☠️#1190

Merged
samtstern merged 61 commits intofirebase:version-3.3.0-devfrom
SUPERCILEX:kickstarter
Mar 23, 2018
Merged

Kill SignInDelegate ☠️#1190
samtstern merged 61 commits intofirebase:version-3.3.0-devfrom
SUPERCILEX:kickstarter

Conversation

@SUPERCILEX
Copy link
Collaborator

@SUPERCILEX SUPERCILEX commented Mar 16, 2018

Built on top of #1188 and #1189.

@SUPERCILEX
Prep for final refactors
a1c7dda 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Perf improvements
3325fda 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix loose ends
fde1bca 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Start addressing review feedback
6f0e2c9 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Move usage updates into getters
624aa6e 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge improvements from future PRs
3acea2d 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX SUPERCILEX requested a review from samtstern as a code owner March 16, 2018 05:28
@samtstern
Copy link
Contributor

samtstern commented Mar 16, 2018

Will review this after the base PRs are in, but I think more PRs should have ☠️ in the title

SUPERCILEX added 22 commits March 16, 2018 10:06
@SUPERCILEX
Address review feedback
dd9ae69 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fancisize tests
887ae0d 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Completely rewrite provider login with new architecture
fdb9f94 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Cleanup and pre-testing bug fixes
5511513 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Make lint happy
1be0b8b 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix tests
0a65776 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
It actually works!
f0dc341 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Kill SignInDelegate ☠️
03efdea 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge remote-tracking branch 'upstream/version-3.3.0-dev' into providers
057c561 
# Conflicts:
#	auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java
#	auth/src/main/java/com/firebase/ui/auth/ui/idp/WelcomeBackIdpPrompt.java
#	auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java
#	auth/src/main/java/com/firebase/ui/auth/util/signincontainer/SignInDelegate.java
#	auth/src/main/java/com/firebase/ui/auth/viewmodel/AuthViewModelBase.java
#	auth/src/main/java/com/firebase/ui/auth/viewmodel/smartlock/SmartLockHandler.java
@SUPERCILEX
Thank you TDD!
7736254 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Start addressing review feedback
4c2eec6 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Restore previous linking behavior
6bf202d 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
3e20621
@SUPERCILEX
Tidy
8360dc6 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Restore previous linking behavior
705b9b9 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
0f9155c
@SUPERCILEX
Fix bugs found in real-world testing plus cleanup
e17c101 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Add hack for googlesamples/google-services#345
27ff4d3 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix WelcomeBackIdpPrompt recursively attempting sign-ins with the sam…
8732c11 
…e provider

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
5f46726
@SUPERCILEX
Cleanup
80c9422 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Tidy loose ends
95b024c 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
SUPERCILEX added 18 commits March 21, 2018 17:09
@SUPERCILEX
Implement new resource usability logic
bbc00f0 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Address some more feedback
e8214a4 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Add back unused tools declaration in strings
6b8eb7f
@SUPERCILEX
Simplify provider dependency tree
43a1d31 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
84363c1
@SUPERCILEX
Fix merge mistakes
f7ac429 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Forgot to make all exceptions be usable
748cbc5 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
9ead908
@SUPERCILEX
Minor cleanup
2fad171 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix pressing back closing all activities
368a6b3 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Address comments
e679f80 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Add back strings and suppress lint
6fec29c
@SUPERCILEX
More simplification
f4ec251 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Squishify the provider classes together
e947030 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Fix welcome back crash if response failed
36a41f2 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
41b9a5e
@SUPERCILEX
Consistency
722f9c6 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Merge branch 'providers' into kickstarter
4f223c5
@samtstern
Copy link
Contributor

samtstern commented Mar 23, 2018

@SUPERCILEX do you think this is something that should be in 3.3.0?

@SUPERCILEX
Merge remote-tracking branch 'upstream/version-3.3.0-dev' into kickst…
f92cdd3 
…arter

# Conflicts:
#	auth/src/main/java/com/firebase/ui/auth/KickoffActivity.java
#	auth/src/main/java/com/firebase/ui/auth/data/remote/FacebookSignInHandler.java
@samtstern samtstern added this to the 3.3.0 milestone Mar 23, 2018
@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Mar 23, 2018

@samtstern For sure, I'd really like to kill all of our setRetainInstance(true) fragments. Permanently. 😈 Also, what's a measly few hundred LoC changed after we just plowed through 3265? 😆

@SUPERCILEX
Remove now unused code
e466caa 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Mar 23, 2018

If this PR goes through, #1057 and #1181 should now be fully addressed.

@samtstern
Copy link
Contributor

samtstern commented Mar 23, 2018

@SUPERCILEX the funny thing about killing all of the retained Fragment instances is that a ViewModel is secretly a retained Fragment.

So the wisdom on retained fragments is officially that they are too powerful for mere mortals, but the spellcasters in Mountain View can distill them down into useful amulets called ViewModels which can improve the life of us villagers :-)

Anyway ... this PR LGTM! Gonna merge.

@samtstern samtstern merged commit acd5384 into firebase:version-3.3.0-dev Mar 23, 2018
@SUPERCILEX SUPERCILEX deleted the kickstarter branch March 23, 2018 16:33
@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Mar 23, 2018

Haha, that's really good! 😂

@samtstern
Copy link
Contributor

samtstern commented Mar 23, 2018

@SUPERCILEX by the way, we can release 3.3.0 as soon as play services 12.0.1 comes out, which should be soon. It contains some critical bugfixes and I wouldn't want to release on 12.0.0

@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Mar 23, 2018

Oh lol, I just made an update PR. I'll let it sit until 12.0.1 comes out then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samtstern samtstern Awaiting requested review from samtstern

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SUPERCILEX @samtstern