Skip to content

Audit consumer proguard rules #878

@samtstern

Description

@samtstern

cc @ashwinraghav who has been helping a developer debug a proguard issue

In #573 the following lines were introduced to the consumer proguard rules:

// REMOVED
-dontwarn retrofit.**		
-dontwarn retrofit2.**		

// ADDED
-dontnote retrofit2.Platform
-dontnote retrofit2.Platform$IOS$MainThreadExecutor
-dontwarn retrofit2.Platform$Java8

Ashwin changed them to this in a branch that seems to solve the developer's issue:

-dontwarn okio.** #safe
-dontwarn retrofit2.Call #safe
#-dontnote retrofit2.Platform #unsafe
#-dontnote retrofit2.Platform$IOS$MainThreadExecutor
-dontwarn retrofit2.Platform$Java8 #safe

Ashwin can you explain what the issue was?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions