Skip to content

Commit

Permalink
hurd: Simplify usleep timeout computation
Browse files Browse the repository at this point in the history
as suggested by Andreas Schwab

* sysdeps/mach/usleep.c (usleep): Divide timeout in an overflow-safe way.
  • Loading branch information
sthibaul committed Jun 29, 2020
1 parent 269e4c1 commit 81b1c8c
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions sysdeps/mach/usleep.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,13 @@ usleep (useconds_t useconds)
{
mach_port_t recv;
int cancel_oldtype;
useconds_t useconds_up = useconds + 999;

if (useconds_up < useconds)
useconds_up = UINT32_MAX;
mach_msg_timeout_t timeout = useconds / 1000 + (useconds % 1000 != 0);

recv = __mach_reply_port ();

cancel_oldtype = LIBC_CANCEL_ASYNC();
(void) __mach_msg (NULL, MACH_RCV_MSG|MACH_RCV_TIMEOUT|MACH_RCV_INTERRUPT,
0, 0, recv, useconds_up / 1000, MACH_PORT_NULL);
0, 0, recv, timeout, MACH_PORT_NULL);
LIBC_CANCEL_RESET (cancel_oldtype);
__mach_port_destroy (mach_task_self (), recv);

Expand Down

0 comments on commit 81b1c8c

Please sign in to comment.