added heroku support #202
Merged
added heroku support #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is unexpected: https://travis-ci.org/fiorix/freegeoip/jobs/189379740 |
|
Any chance you can use https://github.com/kardianos/govendor instead of godep? I've used both in the past but lately have settled on govendor for a number of reasons.. the first being it doesn't create another directory at the root level of your repo, and places its file under vendor/; also it has a much better cmdline interface. |
|
yea no problem, godep is default on heroku so I used that |
added 2 commits
January 6, 2017 14:59
Replacing godep with govendor due to issues with Travis, but also to reduce package size for those who don't care for heroku and keep the repo clean
|
fixed and rebased with master |
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the effort of motivating people to launch their own instance of freegeoip, this adds the ability to "deploy to heroku" with a single click