Purge @finos/perspective-viewer-hypergrid
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHawk
approved these changes
Mar 27, 2020
| | `--d3fc-full--gradient`<br/>`--highcharts-full--gradient` | The color gradient for [-, +] ranges on numeric columns. | | ||
| | `--d3fc-positive--gradient`<br/>`--highcharts-positive--gradient` | The color gradient for [+, +] ranges on numeric columns. | | ||
| | `--d3fc-negative--gradient`<br/>`--highcharts-negative--gradient` | The color gradient for [-, -] ranges on numeric columns. | | ||
| *** Under Construction *** |
There was a problem hiding this comment.
Is there anything specific you would like added here?
There was a problem hiding this comment.
Yes - this API has not been removed, but the new @finos/perspective-viewer-datagrid package has much easier ways to achieve these ends. While the prose documentation for these have not been written, there are a few good examples in the simple example project that will serve as the basis for this section in the future.
| } | ||
|
|
||
| /** | ||
| * Appends the default tbale CSS to `<head>`, should be run once on module |
There was a problem hiding this comment.
You may be interested in this PR/package :) webpack/webpack#10548
… by batching calls to `offsetWidth`
…g in output if `start_row` was a hidden column
texodus
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR principally removes reference to the
@finos/perspective-viewer-hypergridmodule in the project documentation, website and examples, with two exceptions:While pursuing this, several improvements were made to
@finos/perspective-viewer-datagrid, discovered in due course of trying to reimplement all examples and the website without Hypergrid:disable-virtual-datagridattribute, which (for now) allows the developer to disable@finos/perspective-viewer-datagridviewport virtualization. While this will tank performance for large datasets, it makes it easy to use CSS to change the geometry of the datagrid, such as this IEX Cloud powered transposed grid example.Fixes scroll position to remain at the same 'virtual' point on schema-preserving changes such as sort.
Fixes autosize bug when column group headers are wider than their underlying columns.
Fixes an obscure scroll bug when "hidden" sort by columns interplay with column groups.
Refactors
@finos/perspective-viewer-datagridinto much more manageable modules, and adds quite alot of documentation and ASCII art.Also - adds a "radical" new
README.md"Examples" section.