Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misordered columns in update #818

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix misordered columns in update #818

merged 1 commit into from
Nov 18, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Nov 15, 2019

Updates previously used the names property of the table, which may be of a different order than the schema of the t_gnode. Remove the use of names and replace with get_columns() from the gnode schema.

@timkpaine timkpaine added bug Concrete, reproducible bugs Python labels Nov 15, 2019
@texodus
Copy link
Member

texodus commented Nov 18, 2019

Thanks for the PR! Looks good!

@texodus texodus merged commit 013cd59 into master Nov 18, 2019
@texodus texodus deleted the order-fix branch November 18, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc1f @texodus @timkpaine @finos-admin