Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core-js@2 dependency that is required by transpiled outputs of Babel #758

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Oct 10, 2019

Rebased #757 on top of emscripten update fixes.

@finos finos deleted a comment from finos-admin Oct 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #758 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   91.77%   91.87%   +0.09%     
==========================================
  Files          51       51              
  Lines        3162     3162              
==========================================
+ Hits         2902     2905       +3     
+ Misses        260      257       -3
Impacted Files Coverage Δ
perspective/table/_date_validator.py 94.73% <0%> (+7.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa1999...95c4189. Read the comment docs.

@texodus
Copy link
Member Author

texodus commented Oct 10, 2019

Thanks @sebinsua for the fix!

@texodus texodus merged commit 5aa52a9 into master Oct 10, 2019
@texodus texodus deleted the sebinsua-fix/make-core-js-2-dependency-explicit branch October 10, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants