Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite failure feedback #735

Merged
merged 5 commits into from
Sep 22, 2019
Merged

Test suite failure feedback #735

merged 5 commits into from
Sep 22, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 22, 2019

Adds screencap images to test failures for quick debugging.

Screen Shot 2019-09-21 at 11 45 43 PM

@codecov-io
Copy link

codecov-io commented Sep 22, 2019

Codecov Report

Merging #735 into master will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   92.37%   93.15%   +0.77%     
==========================================
  Files          61       62       +1     
  Lines        2703     3011     +308     
==========================================
+ Hits         2497     2805     +308     
  Misses        206      206
Impacted Files Coverage Δ
perspective/table/_date_validator.py 87.5% <0%> (-12.5%) ⬇️
perspective/tests/table/test_to_format.py 100% <0%> (ø) ⬆️
perspective/tests/table/test_table.py 100% <0%> (ø) ⬆️
perspective/core/view.py 100% <0%> (ø)
perspective/table/table.py 91.26% <0%> (+0.26%) ⬆️
perspective/tests/table/test_view.py 98.76% <0%> (+0.29%) ⬆️
perspective/table/view_config.py 97.61% <0%> (+1.19%) ⬆️
perspective/table/_data_formatter.py 96.87% <0%> (+1.63%) ⬆️
perspective/table/_accessor.py 92% <0%> (+1.85%) ⬆️
perspective/core/base.py 91.22% <0%> (+1.99%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0efdd...f97c491. Read the comment docs.

@texodus texodus merged commit 6827d0f into master Sep 22, 2019
@texodus texodus deleted the test-failure branch September 22, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants