Port view to C++ #452
Port view to C++ #452
Conversation
|
the python binding needs a lot of work before it can be fully usable, in the mean time so long as the tests pass feel free to comment out as needed and i'll reimplement later |
| @@ -280,6 +312,137 @@ filter_op_to_str(t_filter_op op) { | |||
| return ""; | |||
| } | |||
|
|
|||
| t_filter_op | |||
| str_to_filter_op(std::string str) { | |||
| if (str == "<") { | |||
There was a problem hiding this comment.
don't like switch statements?
There was a problem hiding this comment.
You can’t switch on a string in C++, so it was this or write another enum that gets mapped to the original enum.
There was a problem hiding this comment.
you can do some stuff, but I think what you've done here is more readable and fine.
Move pivot table operations to C++ move set_depth calls into emscripten.cpp rebase on cpp-subproject move agg + filter to_string methods into base.cpp
Move aggregate and filter parsing to C++ Move aggregate parsing to c++
Construct the View in C++ Fix column pivot issues Make sure that filters work with typed-in dates Fix column-only
|
Thanks for the PR! This looks great and really improves the JS and C++ API code. I've added a few additional cleanup bits and gone ahead and removed the @timkpaine Thanks for the review. Fully agreed on all fronts - we'll definitely need to address these. |
This PR ports the view class to C++ in order to enhance portability and allow for more flexible language bindings.
JS Changes
table.prototype.viewrefactored to pass the config into C++psp_okeyfor column-only views now useview.column_onlyinternal.jshas been marked skip due to change in how we handle incorrect arity aggregates - reenable?C++ changes
Viewclass holds aggregates, pivots, filters, sorts, and at_configobjectt_confighas new constructors and members oriented towards view creationmake_contextis no longer exposed to emscriptenget_aggspecs,get_fterms,get_sortspecnow handle the parsing of config optionsbase.hPython tests do not pass at the moment because function bindings in
binding.hhave been changed. I'm starting the PR as a place where we can review + talk about these changes in the codebase.