Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ subproject #426

Merged
merged 10 commits into from
Feb 15, 2019
Merged

C++ subproject #426

merged 10 commits into from
Feb 15, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 11, 2019

This PR moves the C++ files from the project root to the cpp/ directory, such that the project repo may be shared by multiple C++ projects in the future. It also moves the clean, lint and fix C++ tasks to node.js scripts in the scripts/ folder, such that they may be easily parameterized by project.

@texodus texodus force-pushed the cpp-subproject branch 2 times, most recently from 40340c5 to fc5a628 Compare February 11, 2019 04:17
@timkpaine timkpaine added enhancement Feature requests or improvements C++ labels Feb 11, 2019
@timkpaine
Copy link
Member

@texodus clang-format is not consistent, mine says this is a problem but if I fix it then the test says its a problem
screen shot 2019-02-14 at 10 16 12 am

@texodus texodus merged commit 8760a8f into master Feb 15, 2019
@texodus texodus deleted the cpp-subproject branch February 15, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants