Skip to content

Reorganize ViewPrivate #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2018
Merged

Reorganize ViewPrivate #302

merged 3 commits into from
Nov 12, 2018

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Nov 12, 2018

  • Refactor out DOM manipulation methods
  • Refactor out CancelTask
  • Add toggleConfig() on view.js as a public API method for programmatically interacting with the viewer, thus reducing dependency on internal _toggle_config.
  • Reorder ViewPrivate a little more semantically, with getters at the top followed by update methods. Grouped methods with similar logic/interdependency together.

@texodus texodus merged commit f225a57 into master Nov 12, 2018
@texodus texodus deleted the ViewPrivate_refactor branch November 12, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc1f @texodus