Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python sdist, update docs, add lint to CI #2702

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Fix Python sdist, update docs, add lint to CI #2702

merged 3 commits into from
Aug 4, 2024

Conversation

texodus
Copy link
Member

@texodus texodus commented Aug 3, 2024

  • Fixed Python .whl support for the pre-build PerspectiveWidget based on feedback from v3.0.0-rc.1. We've found two breaks here, both stemming from the disparity between JavaScript's v3.0.0-rc.1 and Python's insistence on stripping this to 3.0.0rc1. (1) PerspectiveWidget using Python importlib to generate the npm model version, and (2) repack_wheel using the package.json version to generate the wheel's data directory name.
  • Add sdist packaging to CI.
  • Add lint step to CI and remove clang-format (and may I say, good riddance).
  • First-pass update to docs, mostly with an eye towards removing deprecated/removed/etc functionality and syntax. Also removes the API docs section entirely, which will be replaced by docs.rs
  • Fixes the link to the build.yaml embedded in the repo's README.md author line CI badge, see this extensive internal discussion or better yet just take my word for it.

texodus and others added 2 commits August 3, 2024 19:48
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus added the bug Concrete, reproducible bugs label Aug 4, 2024
@texodus texodus marked this pull request as ready for review August 4, 2024 00:58
@texodus texodus merged commit 938c513 into master Aug 4, 2024
8 checks passed
@texodus texodus deleted the lint-docs branch August 4, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants