Make perspective-viewer crate importable for external wasm projects
#1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
rust-perspective-viewer
branch
from
58e3d1e to
67f2717
Compare
texodus
changed the title
perspective-rust crate importable for external wasm projectsperspective-viewer crate importable for external wasm projects
texodus
force-pushed
the
rust-perspective-viewer
branch
from
67f2717 to
27e355c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring of
@finos/perspective-viewerto make it nearly possible to import as a pure-rust crate and re-use in a WebAssembly-targetting Rust application. The qualifier "nearly" is important, as neithertrunknorwasm-packcan currently buildperspective-vieweras a dependency. This is due to the lack of a way to referencewasm_bindgengenerated JavaScript symbols from Rust without the assistance of a bundler aware of this "bootstrapping".perspective-viewercan be built with thedefine_web_components_asyncfeature to build without the assistance of external JavaScript.When bootstrapping is possible (presumably in the future?), this work will enable #1892