Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI small fixes #1731

Merged
merged 7 commits into from
Mar 3, 2022
Merged

UI small fixes #1731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a0eeef
Fix theme CSS bugs
texodus Mar 2, 2022
5743070
Fix status-bar 'updating' indicator animation
texodus Mar 2, 2022
4f91257
Fix virtual scroll-panel resize on container resize
texodus Mar 2, 2022
567def2
Fix drag/drop crash
texodus Mar 2, 2022
4eedf5a
Fix missing icon
texodus Mar 2, 2022
e474ed8
Fix tests
texodus Mar 2, 2022
fdbf91d
Fix plugin redraw on split-panel resize
texodus Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@texodus
texodus committed Mar 2, 2022
commit e474ed834fe427f40240975681cbe0b62bb3f853
4 changes: 3 additions & 1 deletion packages/perspective-jupyterlab/test/jupyter/widget.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ const default_body = async (page) => {
await execute_all_cells(page);
const viewer = await page.waitForSelector(
".jp-OutputArea-output perspective-viewer",
{visible: true}
{visible: true, timeout: 60000}
);
await viewer.evaluate(async (viewer) => await viewer.flush());
return viewer;
};

jest.setTimeout(60000);

utils.with_jupyterlab(process.env.__JUPYTERLAB_PORT__, () => {
describe.jupyter(
() => {
Expand Down
6 changes: 4 additions & 2 deletions packages/perspective-viewer-datagrid/test/js/superstore.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ utils.with_server({}, () => {
"perspective-config-update event is fired when column style is changed",
async (page) => {
// Await the viewer element to exist on the page
const viewer = await page.$("perspective-viewer");
const viewer = await page.waitForSelector(
"perspective-viewer"
);
const {x, y} = await page.evaluate(async (viewer) => {
// Await the table load
await viewer.getTable();
Expand Down Expand Up @@ -67,7 +69,7 @@ utils.with_server({}, () => {
await page.mouse.click(x, y);

// Await the style menu existing on the page
const style_menu = await page.$(
const style_menu = await page.waitForSelector(
"perspective-number-column-style"
);

Expand Down
32 changes: 16 additions & 16 deletions rust/perspective-viewer/test/results/results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"superstore.html/doesn't leak elements.": "d0fd18b3d4d7c183c5ed155b4bf37972",
"superstore.html/doesn't leak views when setting group by.": "54daaa4bbbe59f6ed4acc301ba871bab",
"superstore.html/doesn't leak views when setting filters.": "6dfc1e505f1428424c3265f0236f22fc",
"__GIT_COMMIT__": "6c8f089a50c449521ccc3c731fb5b909e6e713c7",
"__GIT_COMMIT__": "b0614dd7fc30b9fb1fd18403df6c8da5a9f5abab",
"blank.html/Handles reloading with a schema.": "e58c62f6e0ff16dc4d753f99e0fc39c3",
"superstore_shows_a_grid_without_any_settings_applied_": "ae1c4690d978598ca14c8669244ce604",
"superstore_Responsive_Layout_shows_horizontal_columns_on_small_vertical_viewports_": "57ba3ad341cf8a0e4df6ab96715ff2a0",
Expand Down Expand Up @@ -57,28 +57,28 @@
"superstore_doesn_t_leak_elements": "8abeada4188bb6c316b8964861a60f43",
"superstore_doesn_t_leak_views_when_setting_group_by": "fd75dd7101bf8501a3271a6c2e5b5032",
"superstore_doesn_t_leak_views_when_setting_filters": "2f523e33ebbec489590323f36fd07dae",
"superstore_opens_settings_when_field_is_set_to_true": "574fa928361a12c1bbd6e8b9aa636e11",
"superstore_opens_settings_when_field_is_set_to_true": "e966e3ce487ec45eecfd1d5ec6541db4",
"superstore_opens_settings_when_field_is_set_to_false": "10d1208b485425756fcc932229386b02",
"superstore_save()_returns_the_current_config": "ded04b5d6cb96a3651578334f189b20e",
"superstore_restore()_restores_a_config_from_save()": "ded04b5d6cb96a3651578334f189b20e",
"superstore_restore()_fires_the__perspective-config-update__event": "ded04b5d6cb96a3651578334f189b20e",
"superstore_restore_fires_the__perspective-config-update__event": "216c2a8ff3d2a50c6addc689a3b98ad1",
"superstore_save_returns_the_current_config": "216c2a8ff3d2a50c6addc689a3b98ad1",
"superstore_restore_restores_a_config_from_save": "f3f29450a3d9c507e7ef9f5b700fecc7",
"superstore_restore_fires_the__perspective-config-update__event": "35d7b01bf3fd1a54b0db1d5cbe49c41b",
"superstore_save_returns_the_current_config": "35d7b01bf3fd1a54b0db1d5cbe49c41b",
"superstore_restore_restores_a_config_from_save": "6cb9eeeed19d93ccf1a8b9e8a756a456",
"Expressions_Click_on_add_column_button_opens_the_expression_UI_": "40bb9b2f39e1cd296752d42c694a4f05",
"Expressions_Resetting_the_viewer_partially_should_not_delete_all_expressions": "b901f4c275d4d23c27122abbfd2b78ac",
"Expressions_Resetting_the_viewer_partially_when_expression_as_in_columns_field,_should_not_delete_all_expressions": "b901f4c275d4d23c27122abbfd2b78ac",
"superstore-all_restore__Bucket_by_year_": "3243fc1f0c30d45d6f103b340547e044",
"superstore-all_restore__Plugin_config_color_mode_": "e15272040eea436c123116c69c11a3e8",
"dragdrop_superstore_drop_from_inactive_to_active_should_add": "0fc0dbc8e27584cf0909aea7b28fd9bd",
"dragdrop_superstore_drop_from_active_to_active_should_swap": "9652f76fc260b957fc97497e969fecb2",
"dragdrop_column-selector-modes_drop_from_inactive_to_required_column_should_add": "19bda13df50d73ab02d1da34e3d32a6a",
"dragdrop_column-selector-modes_drop_from_required_to_required_should_swap": "b2bd48e87fb1290fa60eb0f8b29eb507",
"dragdrop_column-selector-modes_drop_from_required_to_empty_column_should_fail": "20b25f89c36c3bdb1221242bcc4ff8ba",
"dragdrop_column-selector-modes_drop_from_inactive_to_empty_should_add": "ca5e6e73b86915d714fb80555522bc97",
"dragdrop_column-selector-modes_drop_from_named_to_required_should_swap": "a78765050c693e8fb0934d45c64cfd43",
"dragdrop_column-selector-modes_drop_from_optional_to_empty_columns_should_move": "4dcbe74d884b0ead71bbd951eb48c06b",
"dragdrop_column-selector-modes_dragover_from_named_to_required_columns_should_swap": "d99daf643ea8d988b3b64b2586c753d9",
"dragdrop_column-selector-modes_dragover_from_optional_to_empty_columns_should_move": "b33523ac428673d7b77969ec19e200ed",
"dragdrop_column-selector-modes_dragover_from_optional_to_required_columns_should_swap": "9b8acb493b8454d83b6775c6b467828e"
"dragdrop_superstore_drop_from_inactive_to_active_should_add": "ef55833f802abd076f7332badaed11ef",
"dragdrop_superstore_drop_from_active_to_active_should_swap": "9e6ced06930ad8d950c59b92795734f6",
"dragdrop_column-selector-modes_drop_from_inactive_to_required_column_should_add": "1df327a7d7c49b132d2fea159177c3a4",
"dragdrop_column-selector-modes_drop_from_required_to_required_should_swap": "f320d58878c78e289a18b1d412a25ae0",
"dragdrop_column-selector-modes_drop_from_required_to_empty_column_should_fail": "8b4745a18a1b7657db8562be96683c6f",
"dragdrop_column-selector-modes_drop_from_inactive_to_empty_should_add": "499e30b38dc0363c3a4b4a4ca646465c",
"dragdrop_column-selector-modes_drop_from_named_to_required_should_swap": "04bf40275080925cfbe088307271db34",
"dragdrop_column-selector-modes_drop_from_optional_to_empty_columns_should_move": "68ede60f30c38a9b869fa30102d4cad9",
"dragdrop_column-selector-modes_dragover_from_named_to_required_columns_should_swap": "5f24bc15b8e9d79f06184a60beef29ef",
"dragdrop_column-selector-modes_dragover_from_optional_to_empty_columns_should_move": "9415fa9622e5a69cc860d09fc1f8cf5d",
"dragdrop_column-selector-modes_dragover_from_optional_to_required_columns_should_swap": "d50c610fc31d0a4356e31c470fa0c57d"
}