Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wheel build, make extension first to ensure binaries are inlined, then assemble wheel #1679

Merged
merged 2 commits into from
Dec 23, 2021
Merged

fix wheel build, make extension first to ensure binaries are inlined, then assemble wheel #1679

merged 2 commits into from
Dec 23, 2021

Conversation

timkpaine
Copy link
Member

fixes #1677

@timkpaine timkpaine mentioned this pull request Dec 20, 2021
Merged
texodus
texodus approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus
Copy link
Member

texodus commented Dec 23, 2021

Full build CI

@texodus texodus merged commit 0e02b37 into master Dec 23, 2021
@texodus texodus deleted the wheelfix branch December 23, 2021 21:15
@texodus texodus added the internal Internal refactoring and code quality improvement label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing libbinding.pyd in Windows 3.9 1.0.7
2 participants
@timkpaine @texodus