Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python wheel CI #1552

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix python wheel CI #1552

merged 1 commit into from
Sep 29, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 26, 2021

This reverts commit 980ed2d, reversing
changes made to 5a6d0cf.
@timkpaine
Copy link
Member

timkpaine commented Sep 26, 2021

Would be better to remove/fix the line/s in this script that fail

@texodus
Copy link
Member Author

texodus commented Sep 26, 2021

Yes that's exactly what this PR does

@timkpaine
Copy link
Member

That line turns on "if something in the script fails, fail the whole script". If it's presence causes the script to fail, that implies that something else in the script is bad

@texodus
Copy link
Member Author

texodus commented Sep 26, 2021

Yes I understand, the error-ing command is the failing grep (e.g. no wheels). Checking through older builds, It appears these wheels have never worked, you just added set -e without testing it against these environments in #1433

As these failing builds now block CI, I'm reverting the check.

@texodus
Copy link
Member Author

texodus commented Sep 26, 2021

I do see published artifacts for the failing builds though ...

@timkpaine
Copy link
Member

We really do want to check the wheel installs, but maybe bypass it if no wheels present (or maybe we want to fail if not present, I don't know the original logic).

@texodus texodus merged commit 976d768 into master Sep 29, 2021
@texodus texodus deleted the revert-1433 branch September 29, 2021 03:19
@texodus
Copy link
Member Author

texodus commented Sep 29, 2021

@timkpaine broken again

@timkpaine
Copy link
Member

This is because python formats rc as 1.0.0rc whereas it's being tagged as 1.0.0-rc

@texodus texodus added the bug Concrete, reproducible bugs label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants