Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perspective Viewer view dropdowns in dark theme need bg and text color CSS change #592

Closed
RandomFractals opened this issue May 25, 2019 · 1 comment · Fixed by #1287
Closed

Perspective Viewer view dropdowns in dark theme need bg and text color CSS change #592

RandomFractals opened this issue May 25, 2019 · 1 comment · Fixed by #1287
Labels
bug Concrete, reproducible bugs

Comments

@RandomFractals
Copy link

RandomFractals commented May 25, 2019 •
edited
Loading

Bug Report

Currently it displays white bg color with grayed out view options for grid and charts.

Steps to Reproduce in vscode:

  1. Get https://github.com/RandomFractals/vscode-data-preview for a quick test drive in vscode
  2. Change data.preview.theme to .dark in settings
  3. Open any .csv or .json array data file and hit Ctrl+Shift+D

Expected Result:

perspective viewer view selection to show dark dropdown bg color with white text.

Actual Result:

perspective-viewer-view-drop-down-dark-theme-bug

Environment:

any vscode IDE or web client using perspective js lib.
@RandomFractals RandomFractals changed the title Perspective Viewer view dropdown in dark theme needs bg and text color change Perspective Viewer view dropdowns in dark theme need bg and text color CSS change May 25, 2019
@RandomFractals
Copy link
Author

RandomFractals commented May 25, 2019 •
edited
Loading

likewise for aggregate functions dropdown display:

perspective-viewer-dark-theme-aggregates-dropdown-css-bug

I have not looked at your material.dark.css in depth yet, but perhaps a generic select element CSS rule could be a good fix for this minor dark theme UI issue

@timkpaine timkpaine added the bug Concrete, reproducible bugs label May 26, 2019
@RandomFractals RandomFractals mentioned this issue Jun 22, 2019
Closed
texodus added a commit that referenced this issue Jan 12, 2021
@texodus
Fixes style issue with <select> dark theme on Windows (fixes #592)
0a3806b
@texodus texodus mentioned this issue Jan 12, 2021
Merged
texodus added a commit that referenced this issue Jan 17, 2021
@texodus
Fixes style issue with <select> dark theme on Windows (fixes #592)
cac74b6
zepaz pushed a commit to zepaz/perspective that referenced this issue Jan 22, 2021
@texodus @zepaz
Fixes style issue with <select> dark theme on Windows (fixes finos#592)
aa5097c
zepaz added a commit to zepaz/perspective that referenced this issue Jan 22, 2021
@zepaz
Revert "Fixes style issue with <select> dark theme on Windows (fixes f…
a3aa97c 
…inos#592)"

This reverts commit aa5097c.
zepaz added a commit to zepaz/perspective that referenced this issue Jan 22, 2021
@zepaz
Revert "Fixes style issue with <select> dark theme on Windows (fixes f…
ea9118f 
…inos#592)"

This reverts commit aa5097c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes style issue with <select> dark theme on Windows finos/perspective
2 participants
@RandomFractals @timkpaine