Fix tests and compile with bigobj

finos · Apr 5, 2021 · 116411c · 116411c
1 parent dde9f81
commit 116411c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/cpp/perspective/CMakeLists.txt b/cpp/perspective/CMakeLists.txt
@@ -631,6 +631,7 @@ elseif(PSP_CPP_BUILD OR PSP_PYTHON_BUILD)
 		target_compile_definitions(binding PRIVATE PSP_ENABLE_PYTHON=1)
 
         if (WIN32)
+			add_compile_options(/bigobj)
 			target_compile_definitions(binding PRIVATE WIN32=1)
 			target_compile_definitions(binding PRIVATE _WIN32=1)
 

diff --git a/packages/perspective-viewer-d3fc/test/js/integration/line.spec.js b/packages/perspective-viewer-d3fc/test/js/integration/line.spec.js
@@ -24,10 +24,9 @@ utils.with_server({}, () => {
             test.capture("Sets a category axis when pivoted by an expression datetime", async page => {
                 const viewer = await page.$("perspective-viewer");
                 await page.evaluate(async () => await document.querySelector("perspective-viewer").toggleConfig());
-                // just alias the column for now
-                await page.evaluate(element => element.setAttribute("expressions", JSON.stringify(['"Ship Date"'])), viewer);
+                await page.evaluate(element => element.setAttribute("expressions", JSON.stringify([`// abc \n date_bucket("Ship Date", 'M')`])), viewer);
                 await page.waitForSelector("perspective-viewer:not([updating])");
-                await page.evaluate(element => element.setAttribute("row-pivots", JSON.stringify(['"Ship Date"'])), viewer);
+                await page.evaluate(element => element.setAttribute("row-pivots", JSON.stringify(["abc"])), viewer);
                 await page.waitForSelector("perspective-viewer:not([updating])");
                 await page.evaluate(element => element.setAttribute("columns", '["State","Sales"]'), viewer);
                 await page.waitForSelector("perspective-viewer:not([updating])");

diff --git a/packages/perspective-viewer-d3fc/test/results/linux.docker.json b/packages/perspective-viewer-d3fc/test/results/linux.docker.json
@@ -126,7 +126,7 @@
     "treemap_displays_visible_columns_": "42b2a7a20591eb7365376f0916ff9a9d",
     "treemap_with_column_position_1_set_to_null_": "6d6d80945283d945e166bc9ef32c4e02",
     "treemap_tooltip_columns_works": "fad577f81e2853d8d254c950160a63a9",
-    "line_Sets_a_category_axis_when_pivoted_by_an_expression_datetime": "97cbaac322fcb8346e1cb231c26daa0f",
+    "line_Sets_a_category_axis_when_pivoted_by_an_expression_datetime": "7c0b98b3fe6f7481f8b6f936e778f44f",
     "sunburst_sunburst_label_shows_formatted_date": "590f474e076fd49ce10eb5e97bfc66d3",
     "treemap_treemap_label_shows_formatted_date": "e548a05743b0de9e91326d2cba72c875",
     "xyline_shows_a_grid_without_any_settings_applied_": "6d4bdd941a04d6e39fe14c2ea001886e",

diff --git a/packages/perspective/test/arrow/all_types_small_multi.arrow b/packages/perspective/test/arrow/all_types_small_multi.arrow