Skip to content

refactor(gleam-binding): eliminate memory duplication in compile response #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamianReeves merged 2 commits into from
Jan 24, 2026
Merged

refactor(gleam-binding): eliminate memory duplication in compile response #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0239fa4
Initial plan
Copilot Jan 24, 2026
a4f17c9
refactor: avoid disk I/O for format.json in compile response
Copilot Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/morphir-gleam-binding/src/frontend/visitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ impl<V: Vfs> GleamToMorphirVisitor<V> {
}
}

/// Build format.json structure in memory without disk I/O
pub fn build_format_json(&self) -> serde_json::Value {
serde_json::json!({
"formatVersion": "4.0.0",
"distribution": "Library",
"packageName": self.package_name.to_string(),
"layout": "VfsMode"
})
}

/// Visit module and write Document Tree structure
fn visit_module_vfs_mode(&self, module_ir: &ModuleIR) -> Result<()> {
// Create .morphir-dist/pkg/package-name/module-path/ structure
Expand Down
48 changes: 6 additions & 42 deletions crates/morphir-gleam-binding/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//! - Frontend: Parse Gleam source files to Morphir IR
//! - Backend: Generate Gleam code from Morphir IR

use morphir_common::vfs::{OsVfs, Vfs};
use morphir_common::vfs::OsVfs;
use morphir_extension_sdk::prelude::*;
use morphir_ir::naming::{ModuleName, PackageName};
use std::path::PathBuf;
Expand Down Expand Up @@ -103,47 +103,11 @@ impl Frontend for GleamExtension {

match visitor.visit_module_v4(&module_ir) {
Ok(_) => {
// Read format.json as IR representation
// output_dir is already .morphir/out/<project>/compile/<language>/
let format_json_path = output_dir.join("format.json");
let vfs = OsVfs;
if vfs.exists(&format_json_path) {
match vfs.read_to_string(&format_json_path) {
Ok(format_content) => {
match serde_json::from_str::<serde_json::Value>(
&format_content,
) {
Ok(ir_json) => {
ir_modules.push(ir_json);
}
Err(e) => {
diagnostics.push(Diagnostic {
severity: DiagnosticSeverity::Error,
code: Some("E002".into()),
message: format!(
"Failed to parse format.json: {}",
e
),
location: None,
related: vec![],
});
}
}
}
Err(e) => {
diagnostics.push(Diagnostic {
severity: DiagnosticSeverity::Error,
code: Some("E003".into()),
message: format!("Failed to read format.json: {}", e),
location: None,
related: vec![],
});
}
}
} else {
// Fallback: serialize ModuleIR directly
ir_modules.push(serde_json::to_value(&module_ir)?);
}
// Build format.json in memory without disk I/O
// This avoids reading the entire file back after writing it,
// which could cause memory issues for large projects
let ir_json = visitor.build_format_json();
ir_modules.push(ir_json);
}
Err(e) => {
diagnostics.push(Diagnostic {
Expand Down