feat: Add Annotated Tag Push Support#1139
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 85.51% 85.67% +0.16%
==========================================
Files 83 83
Lines 7878 7967 +89
Branches 1312 1342 +30
==========================================
+ Hits 6737 6826 +89
Misses 1114 1114
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jescalada
left a comment
There was a problem hiding this comment.
The core flow seems to work correctly! Just a few edge cases and an integration issue with the checkEmptyBranch that might be worth refactoring.
Also, we will be merging #973 soon which will likely cause a few conflicts here... Might want an extra pair of eyes to make sure everything is good to merge.
|
Updated with the latest changes of main and manually tested also with gitlab |
jescalada
left a comment
There was a problem hiding this comment.
Looks good to me! I tested the tags and regular push flow and both work as expected with the new updates 👍🏼
Just a comment on the parsePush which I'm not sure if it's executing once or twice on pushes.
|
As we're modifying the proxy logic, another pair of eyes here would be super helpful! 👀 @finos/git-proxy-maintainers |
29f0646 to
8da3da4
Compare
8da3da4 to
8dec82c
Compare
|
Resolved comments that have been dealt with already |
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>
|
LGTM so far, the general flow is still working as expected, and the double Just a few issues to iron out:
|
|
All review comments have been addressed. Ready for a final look! @kriswest @jescalada |
jescalada
left a comment
There was a problem hiding this comment.
LGTM! 🚀 Just checked that existing comments have been resolved.
Description:
This PR introduces end-to-end support for annotated tag pushes
branchPushChainandtagPushChain.getChain()to select the correct chain based onaction.typeand presence ofaction.tag.Fixes #986