Skip to content

feat: Add Annotated Tag Push Support#1139

Merged
jescalada merged 41 commits into
finos:mainfrom
fabiovincenzi:push-tags
Jun 26, 2026
Merged

feat: Add Annotated Tag Push Support#1139
jescalada merged 41 commits into
finos:mainfrom
fabiovincenzi:push-tags

Conversation

@fabiovincenzi

@fabiovincenzi fabiovincenzi commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Description:
This PR introduces end-to-end support for annotated tag pushes

  • Split the push pipeline into separate branchPushChain and tagPushChain.
  • Update getChain() to select the correct chain based on action.type and presence of action.tag.
  • Render a dedicated “Tag Details” table when viewing a tag push instead of the commit diff.

Fixes #986

@netlify

netlify Bot commented Aug 4, 2025

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1bab1cc
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a3e53179aebdd000893a369

@codecov

codecov Bot commented Aug 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (f0871ea) to head (1bab1cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   85.51%   85.67%   +0.16%     
==========================================
  Files          83       83              
  Lines        7878     7967      +89     
  Branches     1312     1342      +30     
==========================================
+ Hits         6737     6826      +89     
  Misses       1114     1114              
  Partials       27       27              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/proxy/processors/push-action/parsePush.ts Outdated
Comment thread src/proxy/processors/push-action/parsePush.ts Outdated
Comment thread src/proxy/processors/push-action/parsePush.ts Outdated
Comment thread src/proxy/processors/push-action/parsePush.ts Outdated
Comment thread src/proxy/processors/push-action/parsePush.ts Outdated

@jescalada jescalada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core flow seems to work correctly! Just a few edge cases and an integration issue with the checkEmptyBranch that might be worth refactoring.

Also, we will be merging #973 soon which will likely cause a few conflicts here... Might want an extra pair of eyes to make sure everything is good to merge.

@fabiovincenzi

Copy link
Copy Markdown
Contributor Author

Updated with the latest changes of main and manually tested also with gitlab

Comment thread src/proxy/chain.ts Outdated

@jescalada jescalada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I tested the tags and regular push flow and both work as expected with the new updates 👍🏼

Just a comment on the parsePush which I'm not sure if it's executing once or twice on pushes.

@jescalada jescalada requested a review from a team August 27, 2025 10:10
@jescalada

Copy link
Copy Markdown
Contributor

As we're modifying the proxy logic, another pair of eyes here would be super helpful! 👀 @finos/git-proxy-maintainers

@kriswest

Copy link
Copy Markdown
Contributor

Resolved comments that have been dealt with already

Comment thread src/proxy/processors/pre-processor/parsePush.ts
Comment thread src/ui/utils/pushUtils.ts
Comment thread src/proxy/chain.ts Outdated
Comment thread src/proxy/chain.ts Outdated
Comment thread src/proxy/chain.ts Outdated
@jescalada

Copy link
Copy Markdown
Contributor

LGTM so far, the general flow is still working as expected, and the double parsePush issue is fixed 👍🏼

Just a few issues to iron out:

  • Empty tag pushes give a missing user error which is misleading
  • We should figure out whether to refactor the chains to contain parsePush again (which makes intuitive sense)
    • Otherwise, we can make parsePush a pre-processor, considering it pre-processes pushes to define what type of Git object is being pushed, and consequentially which push chain must be executed (branchPushChain, tagPushChain or something else).

Comment thread src/proxy/actions/Action.ts Outdated
@fabiovincenzi

Copy link
Copy Markdown
Contributor Author

All review comments have been addressed. Ready for a final look! @kriswest @jescalada

Comment thread src/proxy/processors/pre-processor/parsePush.ts Outdated

@jescalada jescalada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Just checked that existing comments have been resolved.

@jescalada jescalada merged commit 7fe2e29 into finos:main Jun 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for pushing tags git push --tags Add support for pushing tags git push --tags

4 participants