Skip to content

test: stop the config loader and restore defaults after tests have run #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

kriswest
Copy link
Contributor

resolves #1049

Clean up after the Config Loader tests by making sure reloads are stopped and the default config is reloaded. This improves (reduces) spurious log output through the rest of the tests.

@kriswest
Copy link
Contributor Author

@JamieSlome and @finos/git-proxy-maintainers I was encountering this in multiple open PRs and fixed it. Would be good to get it merged ASAP, but no need for a release.

Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 174baae
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6848659102608c0008fb9b8c

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (67663a9) to head (174baae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   70.29%   70.15%   -0.14%     
==========================================
  Files          54       54              
  Lines        2205     2205              
  Branches      248      248              
==========================================
- Hits         1550     1547       -3     
- Misses        624      627       +3     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamieSlome JamieSlome merged commit 6d0a90d into finos:main Jun 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config loader tests don't reset the config loader
2 participants