Skip to content

test: improve config test coverage #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 5, 2025

Conversation

jescalada
Copy link
Contributor

@jescalada jescalada commented May 24, 2025

This PR increases test coverage for src/config by testing many of the missing logic branches and helper functions.

Copy link

netlify bot commented May 24, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit c69427b
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/684158cbb7713100099f3331
😎 Deploy Preview https://deploy-preview-1032--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.28%. Comparing base (a3834ab) to head (c69427b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/config/ConfigLoader.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   60.15%   63.28%   +3.12%     
==========================================
  Files          53       53              
  Lines        2196     2187       -9     
  Branches      250      245       -5     
==========================================
+ Hits         1321     1384      +63     
+ Misses        840      774      -66     
+ Partials       35       29       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada force-pushed the improve-config-test-coverage branch from 40299be to a30faaa Compare May 24, 2025 08:31
@jescalada jescalada force-pushed the improve-config-test-coverage branch from 67a0dbb to 39a7974 Compare May 25, 2025 03:48
@jescalada jescalada marked this pull request as ready for review May 26, 2025 10:14
@JamieSlome JamieSlome self-requested a review June 5, 2025 08:44
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 6f7032f into finos:main Jun 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: Improve test coverage for OIDC and authentication changes
2 participants