Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog for 2.2 #1440

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

kemerava
Copy link
Contributor

@kemerava kemerava commented Nov 15, 2024

Describe your change

Related Issue

resolves #1416

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?
  • API changes: Does this PR include changes to any of the FDC3 APIs (DesktopAgent, Channel, PrivateChannel, Listener, Bridging)?
    • Docs & Sources: If yes, were both documentation (/docs) and sources updated?

      JSDoc comments on interfaces and types should be matched to the main documentation in /docs
    • Conformance tests: If yes, are conformance test definitions (/toolbox/fdc3-conformance) still correct and complete?

      Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
    • Schemas: If yes, were changes applied to the Bridging and FDC3 for Web protocol schemas?

      The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
      • If yes, was code generation (npm run build) run and the results checked in?

        Generated code will be found at /src/api/BrowserTypes.ts and/or /src/bridging/BridgingTypes.ts
  • Context types: Were new Context type schemas created or modified in this PR?
    • Were the field type conventions adhered to?
    • Was the BaseContext schema applied via allOf (as it is in existing types)?
    • Was a title and description provided for all properties defined in the schema?
    • Was at least one example provided?
    • Was code generation (npm run build) run and the results checked in?

      Generated code will be found at /src/context/ContextTypes.ts
  • Intents: Were new Intents created in this PR?

@kemerava kemerava requested a review from a team as a code owner November 15, 2024 18:27
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit 6119f6d
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/6740efba1c84ba00089a189f

@kemerava
Copy link
Contributor Author

@kriswest do we want to add CHANGELOG for #1345 (it was merged into the web, so maybe it would be updated there?) and #1079 (this one I am not sure if we want the CHANGELOG for)?

@kriswest
Copy link
Contributor

#1345 is fine without a change log as it's just part of implementing FDC3 for the Web.

#1079 does need a change log entry, and I'm amazed I didn't give it one! The first few bullets from the description contain the relevant info.

@kemerava
Copy link
Contributor Author

#1345 is fine without a change log as it's just part of implementing FDC3 for the Web.

#1079 does need a change log entry, and I'm amazed I didn't give it one! The first few bullets from the description contain the relevant info.

Done, thanks @kriswest

kriswest
kriswest previously approved these changes Nov 22, 2024
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for doing this, suggested some clarificaiton on #1139

Co-authored-by: Kris West <kris.west@interop.io>
@kemerava
Copy link
Contributor Author

Thanks for additional suggestions, @kriswest! Added

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest merged commit 071f72a into finos:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update changelog for FDC3 2.2
2 participants