-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance server side validation of existing aggregates #196
Enhance server side validation of existing aggregates #196
Conversation
…regates + tests Signed-off-by: HaniAlshikh <Alshikh.hani@gmail.com>
Signed-off-by: HaniAlshikh <Alshikh.hani@gmail.com>
LGTM but as we are on this anyhow we should make sure that all strings are trimmed when aggregates are created/updated. Your change handles that things are compared trimmed, but they would still be stored with whitespace. Could you look into that too please? |
Oh yeah, I really feel ashamed for missing this point. I think I was too concentrated on the |
Signed-off-by: HaniAlshikh <Alshikh.hani@gmail.com>
We discussed this again and decided that it's not the Server's job to do any cleanup or data modification, as this will implay side-effects the client might not have accounted for therefore we will make the command data validation more strict and expect the client to handle any cleanup if necessary |
Signed-off-by: HaniAlshikh <Alshikh.hani@gmail.com>
…f-existing-aggregates
Signed-off-by: HaniAlshikh <Alshikh.hani@gmail.com>
Currently two tenants with the same name but different case could be created. This must not be possible! For all other aggregates the name must be case insensitive unique!