Skip to content

Commit

Permalink
Mark FittingSubgroup and FrattiniSubgroup as nilpotent
Browse files Browse the repository at this point in the history
The Frattini and Fitting subgroups of finite groups are always nilpotent.
See issue gap-system#398.
  • Loading branch information
fingolfin committed Jan 19, 2016
1 parent f6066ee commit 476e97d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
14 changes: 9 additions & 5 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -996,13 +996,13 @@ InstallMethod( FittingSubgroup,
"generic method for groups",
[ IsGroup and IsFinite ],
function (G)
if IsTrivial (G) then
return G;
else
return SubgroupNC( G, Filtered(Union( List( Set( FactorsInt( Size( G ) ) ),
if not IsTrivial( G ) then
G := SubgroupNC( G, Filtered(Union( List( Set( FactorsInt( Size( G ) ) ),
p -> GeneratorsOfGroup( PCore( G, p ) ) ) ),
p->p<>One(G)));
SetIsNilpotentGroup( G, true );
fi;
return G;
end);

RedispatchOnCondition( FittingSubgroup, true, [IsGroup], [IsFinite], 0);
Expand All @@ -1019,7 +1019,11 @@ local m;
return G;
fi;
m:=List(ConjugacyClassesMaximalSubgroups(G),C->Core(G,Representative(C)));
return Intersection(m);
m := Intersection(m);
if HasIsFinite(G) and IsFinite(G) then
SetIsNilpotentGroup(m,true);
fi;
return m;
end);


Expand Down
4 changes: 3 additions & 1 deletion lib/grppcatr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ InstallMethod( FrattiniSubgroup,
0,

function( G )
return Core( G, PrefrattiniSubgroup( G ) );
G := Core( G, PrefrattiniSubgroup( G ) );
SetIsNilpotentGroup( G, true );
return G;
end);


Expand Down
3 changes: 3 additions & 0 deletions lib/maxsub.gi
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,9 @@ local m,f,i;
f:=Core(G,NormalIntersection(f,m[i]));
fi;
od;
if HasIsFinite(G) and IsFinite(G) then
SetIsNilpotentGroup(f,true);
fi;
return f;
end);

Expand Down

0 comments on commit 476e97d

Please sign in to comment.