Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DocumentsDirectoryAttributesProviding protocol #53

Merged

Conversation

josipzavada
Copy link
Contributor

Summary

This PR focuses on cleanup by removing unused properties and protocols that are no longer utilized in the codebase.

Changes

  • Removed DocumentsDirectoryAttributesProviding protocol: No longer required.
  • Removed DocumentsDirectoryAttributesProvidingMock protocol: No longer utilized.
  • Removed FileManager+DocumentsDirectoryAttributesProviding extension: No dependencies rely on it.
  • Removed fileManager parameter from HardwareInfoHarvester: Simplified the API by eliminating an unused parameter.

Notes

All tests have been executed and are passing ✅

…th its mock. Remove fileManager property from the HardwareInfoHarveseter.
@mgutski mgutski force-pushed the feature/remove-unused-protocol branch from 154a39d to f49e457 Compare December 6, 2024 16:21
@mgutski mgutski self-requested a review December 13, 2024 12:31
@mgutski mgutski merged commit c9134b4 into fingerprintjs:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants