Add recommended VS Code settings and extensions#156
Conversation
|
Your This brings up another issue, though. Is it wise to force everyone to have the same |
These settings will only affect this current repository. You can still have your own settings in the "User" scope. However, any settings included in this |
I do have Unless they do, I'd recommend not adding them to this |
|
I guess my discomfort with this PR stems from the fact that it will be very easy to modify the Of course, I can easily change to not do that, but every user of this repo is likely to have slightly different work habits and preferences. It could become difficult to manage them all. I am wondering if instead of including |
|
Hmm, that does make sense. The
I can update the
This is true, but I feel like we can easily catch this in code review. |
|
Should we add this line to "lua.targetVersion": "5.2", |
That would be a good idea. |
|
I'm not seeing a setting named "Lua.runtime.version": "Lua 5.2" |
resolve vs code settings objections fix .gitignore
094311a to
fb72ea4
Compare
|
I've updated the settings to hopefully resolve your hesitations.
|
|
Some extension somewhere added it to my settings.json. Maybe it was that debugger. BTW I have a whole At any rate, I suppose Also, feel free to go ahead and merge this one. |
Because of the ongoing efforts to resolve #5, I decided to add my current VS Code settings and extensions to the
.vscodefolder.In theory, this does two things:
That means we can help make everyone's development environment consistent. And aside from pressing the button to "download recommended extensions", developers won't need to do anything to setup VS Code.
To be honest, I've never done this before so it may not work as expected. But it's potentially worth a shot. At the very least, it might resolve the existing VS Code code formatting issue since we'll share the same settings and extensions.
The may drawback is that if anyone has a
.vscodefolder in their local version of the repo, their settings may also get unintentionally added.