Markdown in notes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, thank you. Do you need me to merge it? |
|
Thanks, just wanted another pair of eyes on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rpatters1 This will get you bold, italic, and headers when displaying the notes for a script. Note that h4-h6 will be styled just like h3; I can add specific styling for these, but I thought it was unlikely that they would be needed.
Tables are more complicated, because of spacing and alignment; I was able to emit the proper HTML, but I wasn't happy with the way things looked. By default, a table will take up the full width of its container (likely larger than needed), and table headers will be center-aligned. I'm not sure how to impose reasonable defaults, and I don't want to get into allowing styling directly in the Markdown.