Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ip_group_id to firewall zone policy to support firewall groups of address-group type (ipv4) #39

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

filipowm
Copy link
Owner

@filipowm filipowm commented Mar 2, 2025

fixes #38

…all groups of address-group type (ipv4)

fixes #38
@filipowm filipowm self-assigned this Mar 2, 2025
@github-actions github-actions bot added the fix label Mar 2, 2025
Copy link

github-actions bot commented Mar 2, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/filipowm/go-unifi/unifi 9.63% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/filipowm/go-unifi/unifi/firewall_zone_policy.generated.go 0.00% (ø) 56 0 56

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@filipowm filipowm merged commit 4e6e9d9 into main Mar 2, 2025
11 checks passed
@filipowm filipowm deleted the fix/firewall-policy-missing-ip-groups branch March 16, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IP firewall groups are not supported in firewall zone policies
1 participant