[KEYCLOAK-6142] Updated OTP manual config pages to reflect HOTP

filipeferraz · Jan 25, 2018 · 0f1644e · 0f1644e
1 parent 64b75d2
commit 0f1644e
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/.../tests/base/src/test/java/org/keycloak/testsuite/actions/RequiredActionTotpSetupTest.java b/.../tests/base/src/test/java/org/keycloak/testsuite/actions/RequiredActionTotpSetupTest.java
@@ -219,7 +219,7 @@ public void setupTotpModifiedPolicy() {
             assertEquals("Type: Counter-based", driver.findElement(By.id("kc-totp-type")).getText());
             assertEquals("Algorithm: HmacSHA256", driver.findElement(By.id("kc-totp-algorithm")).getText());
             assertEquals("Digits: 8", driver.findElement(By.id("kc-totp-digits")).getText());
-            assertEquals("Interval: 30", driver.findElement(By.id("kc-totp-period")).getText());
+            assertEquals("Counter: 0", driver.findElement(By.id("kc-totp-counter")).getText());
         } finally {
             rep.setOtpPolicyDigits(6);
             rep.setOtpPolicyType("totp");

diff --git a/themes/src/main/resources/theme/base/account/messages/messages_en.properties b/themes/src/main/resources/theme/base/account/messages/messages_en.properties
@@ -114,6 +114,7 @@ totpType=Type
 totpAlgorithm=Algorithm
 totpDigits=Digits
 totpInterval=Interval
+totpCounter=Counter
 
 missingUsernameMessage=Please specify username.
 missingFirstNameMessage=Please specify first name.

diff --git a/themes/src/main/resources/theme/base/account/totp.ftl b/themes/src/main/resources/theme/base/account/totp.ftl
@@ -51,7 +51,11 @@
                 <li id="kc-totp-type">${msg("totpType")}: ${msg("totp." + totp.policy.type)}</li>
                 <li id="kc-totp-algorithm">${msg("totpAlgorithm")}: ${totp.policy.algorithm}</li>
                 <li id="kc-totp-digits">${msg("totpDigits")}: ${totp.policy.digits}</li>
-                <li id="kc-totp-period">${msg("totpInterval")}: ${totp.policy.period}</li>
+                <#if totp.policy.type = "totp">
+                    <li id="kc-totp-period">${msg("totpInterval")}: ${totp.policy.period}</li>
+                <#elseif totp.policy.type = "hotp">
+                    <li id="kc-totp-counter">${msg("totpCounter")}: ${totp.policy.initialCounter}</li>
+                </#if>
             </ul>
         </li>
     <#else>

diff --git a/themes/src/main/resources/theme/base/login/login-config-totp.ftl b/themes/src/main/resources/theme/base/login/login-config-totp.ftl
@@ -30,7 +30,11 @@
                     <li id="kc-totp-type">${msg("loginTotpType")}: ${msg("loginTotp." + totp.policy.type)}</li>
                     <li id="kc-totp-algorithm">${msg("loginTotpAlgorithm")}: ${totp.policy.algorithm}</li>
                     <li id="kc-totp-digits">${msg("loginTotpDigits")}: ${totp.policy.digits}</li>
-                    <li id="kc-totp-period">${msg("loginTotpInterval")}: ${totp.policy.period}</li>
+                    <#if totp.policy.type = "totp">
+                        <li id="kc-totp-period">${msg("loginTotpInterval")}: ${totp.policy.period}</li>
+                    <#elseif totp.policy.type = "hotp">
+                        <li id="kc-totp-counter">${msg("loginTotpCounter")}: ${totp.policy.initialCounter}</li>
+                    </#if>
                 </ul>
             </li>
         <#else>

diff --git a/themes/src/main/resources/theme/base/login/messages/messages_en.properties b/themes/src/main/resources/theme/base/login/messages/messages_en.properties
@@ -80,6 +80,7 @@ loginTotpType=Type
 loginTotpAlgorithm=Algorithm
 loginTotpDigits=Digits
 loginTotpInterval=Interval
+loginTotpCounter=Counter
 
 loginTotp.totp=Time-based
 loginTotp.hotp=Counter-based