fix(submit): trim new word before using #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipdutescu
force-pushed
the
fix/padding_used_in_renaming
branch
3 times, most recently
from
8e4b135
to
6e995bc
Compare
Trim the new word of leading and ending spaces before using it to rename. This should prevent padding from being used in the final name, as well as making it a bit more logic and consistent with most IDEs. Fixes: GH-119 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu
force-pushed
the
fix/padding_used_in_renaming
branch
from
6e995bc
to
9323e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trim the new word of leading and ending spaces before using it to rename. This should prevent padding from being used in the final name, as well as making it a bit more logic and consistent with most IDEs.
Fixes: GH-119
Proposed changes
new_wordspaces on submit (as seen in this StackOverflow question)Test plan
Existing tests are updated and a new test case is added in
lua/tests/rename_close_spec.lua.