Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] If the first row of a file is changed by rename, quickfix list is not properly set. #79

Closed
filipdutescu opened this issue Nov 13, 2021 · 0 comments · Fixed by #80
Closed

[Bug] If the first row of a file is changed by rename, quickfix list is not properly set. #79

filipdutescu opened this issue Nov 13, 2021 · 0 comments · Fixed by #80
Assignees
@filipdutescu
Labels
bug Something isn't working
Milestone
v2.0.0

Comments

@filipdutescu
Copy link
Owner

Describe the bug

If the first row of a file is changed by rename, quickfix list is not properly set.

To reproduce

Steps to reproduce the behavior:

  1. Setup renamer with qf list
  2. Rename a word in the first line of a file
  3. Open quickfix list (:copen)
  4. See error

Expected behavior

The first row should be properly set.

Environment

  • Renamer: develop
  • Neovim: v0.5.0
  • OS: ArchLinux

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.
@filipdutescu filipdutescu added the bug Something isn't working label Nov 13, 2021
@filipdutescu filipdutescu added this to the v2.0.0 milestone Nov 13, 2021
@filipdutescu filipdutescu self-assigned this Nov 13, 2021
filipdutescu added a commit that referenced this issue Nov 13, 2021
@filipdutescu
fix(qflist): first line in file was not set correctly
886c61b 
Remove unnecessary modification of first row, in `utils.set_qf_list()`,
in order to properly populate the list.

Closes: GH-79
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
@filipdutescu filipdutescu mentioned this issue Nov 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipdutescu filipdutescu

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix(qflist): first line in file was not set correctly filipdutescu/renamer.nvim
1 participant
@filipdutescu