Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of small fixes #17

Merged
merged 16 commits into from
Nov 7, 2021
Merged

A bunch of small fixes #17

merged 16 commits into from
Nov 7, 2021

Conversation

TheOnlyTails
Copy link
Contributor

@TheOnlyTails TheOnlyTails commented Oct 5, 2021

  • Meta images now load correctly based on the page #6
  • The error window now has a min width and height
  • Fixed the text wrapping issue on the file preview showcase #14
  • Fixed a typo on the file preview showcase
  • Use the new "mini" mode of the new Microsoft store popup
  • Only use logical CSS properties (change based on writing direction)
  • Fix Windows OS detection. #18
  • Adapt to the new zip release format on GitHub.
  • Fixed inline code wrapping in markdown. #44
  • Updated packages.

Closes #6, #14, #18, #44

- Meta images now load correctly based on the page
- The error window now has a min width and height
- Fixed the text wrapping issue on the file preview showcase
- Fixed a typo on the file preview showcase
- Updated packages.

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for flamboyant-swanson-df593f ready!

🔨 Explore the source changes: 1a38a15

🔍 Inspect the deploy log: https://app.netlify.com/sites/flamboyant-swanson-df593f/deploys/6186db263636a10008526565

😎 Browse the preview: https://deploy-preview-17--flamboyant-swanson-df593f.netlify.app

Capitalized "GitHub" correctly in the dropdown menu;
The footer social icons are now imported using a relative path;
Updated packages;

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
@TheOnlyTails TheOnlyTails added the enhancement New feature or request label Nov 4, 2021
@TheOnlyTails
Copy link
Contributor Author

@chingucoding and I have decided to merge this PR in its current state. All the undone changes will be done in separate PRs.

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like that the contributor cards are behaving a bit strangely now:

Screenshot of missing contributor cards in the contributors section

Otherwise, the changes look good to me.

@TheOnlyTails
Copy link
Contributor Author

Hmm, I'll take a look. Probably something to do with the scrolling animation direction. Should be an easy fix.

Small formatting fixes.
Updated packages.

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Small formatting fixes.

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
…d after install.

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
@TheOnlyTails
Copy link
Contributor Author

Should be done now! I've also added the ability to select the tabs in the tab showcase, and a pre-commit Git hook with Husky to automatically upgrade packages before commiting.

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for fixing all those bugs!

Fixed Windows OS detection.
Added a hover effect to the placeholder files in the tabs showcase.

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
@TheOnlyTails TheOnlyTails linked an issue Nov 6, 2021 that may be closed by this pull request
1 task
Closes #44

Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
@TheOnlyTails TheOnlyTails linked an issue Nov 6, 2021 that may be closed by this pull request
1 task
Copy link
Contributor

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheOnlyTails TheOnlyTails merged commit 7e27b8a into main Nov 7, 2021
@TheOnlyTails TheOnlyTails deleted the general-fixes branch November 7, 2021 05:40
@0x5bfa
Copy link
Member

0x5bfa commented Nov 7, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants