-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of small fixes #17
Conversation
- Meta images now load correctly based on the page - The error window now has a min width and height - Fixed the text wrapping issue on the file preview showcase - Fixed a typo on the file preview showcase - Updated packages. Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
✔️ Deploy Preview for flamboyant-swanson-df593f ready! 🔨 Explore the source changes: 1a38a15 🔍 Inspect the deploy log: https://app.netlify.com/sites/flamboyant-swanson-df593f/deploys/6186db263636a10008526565 😎 Browse the preview: https://deploy-preview-17--flamboyant-swanson-df593f.netlify.app |
Capitalized "GitHub" correctly in the dropdown menu; The footer social icons are now imported using a relative path; Updated packages; Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
because netlify, that's why
…o general-fixes
@chingucoding and I have decided to merge this PR in its current state. All the undone changes will be done in separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'll take a look. Probably something to do with the scrolling animation direction. Should be an easy fix. |
Small formatting fixes. Updated packages. Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Small formatting fixes. Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
…d after install. Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Should be done now! I've also added the ability to select the tabs in the tab showcase, and a pre-commit Git hook with Husky to automatically upgrade packages before commiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for fixing all those bugs!
Fixed Windows OS detection. Added a hover effect to the placeholder files in the tabs showcase. Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
Closes #44
Signed-off-by: TheOnlyTails <theonlytails@theonlytails.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Closes #6, #14, #18, #44