Skip to content

Remove WindowDecorationsHelper, fix theme in properties window #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 9, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Changes

  • Removed AppWindowTitleBar.IsCustomizationSupported() check, not necessary as of winappsdk 1.2 (titlebar API supported down to 1809)
  • Removed WindowDecorationsHelper, uwp only + same reason as above
  • Removed code for custom titlebar close button (it was commented), we now use the standard close button
  • Fix wrong background in properties window when theme changes
  • Fix crash when clicking "share", remove call to GetForCurrentView() (uwp only)
  • Restore code for changing titlebar buttons on theme change
  • Improve positioning of properties window (do not go out of screen bounds)

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Sep 11, 2022

Restore code for changing titlebar buttons on theme change

@gave92 this seems to help for the main window, but the issue still exists with the property windows.

@gave92
Copy link
Member Author

gave92 commented Sep 11, 2022

Should be good now.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit b3a2646 into files-community:main Sep 12, 2022
@gave92 gave92 deleted the titlebar branch September 12, 2022 06:32
@files-community files-community deleted a comment from Fahhd1400 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Title bar close/minimize/maximize buttons color don't match the app theme
2 participants